BIP-325: Signet (consensus, validation)

https://github.com/bitcoin/bitcoin/pulls/18267

Host: pinheadmz  -  PR author: kallewoof

The PR branch HEAD was a25a5e42 at the time of this review club meeting.

Signet!

The Bitcoin wiki defines signet as β€œa proposed new test network for the Bitcoin block chain which adds an additional signature requirement to block validation.”

This pull request implements the portion of BIP325 responsible for connecting to a signet network and validating blocks (it does not implement the code required by miners to sign signet blocks). We are touching consensus-critical code today! Let’s make sure we do it right :-)

Because this PR is rather large, we are going to focus on the first four commits:

Once the PR branch is built, you can connect to signet by creating a new data directory and launching the development build of Bitcoin Core:

# make a new data directory
$ mkdir /absolute/path/to/datadir/for/signet

# enter the bitcoin repo where this PR is built locally
$ cd bitcoin

# launch!
$ src/bitcoind -signet -datadir=/absolute/path/to/datadir/for/signet

# generate a signet address
$ src/bitcoin-cli -signet -datadir=/absolute/path/to/datadir/for/signet getnewaddress

Notes

  • The PR author, kallewoof, maintains a signet faucet. If you can run the branch and generate a signet address, you can request a payout!

  • At the start of this meeting, I’ll ask everyone for their signet address and reward participants who answer questions correctly or ask their own good questions!

Questions

  1. Why do we need test networks and what problems (if any) do we have with the current testnet?

  2. What are some of the parameters that distinguish mainnet, testnet and signet? Which of these do the different networks have in common? What makes signet special?

  3. How many signets are there? Could we start our own just for review club, and if so, how?

  4. What parts of this PR affect consensus-critical code for nodes running on mainnet?

  5. What new configuration options have been added?

  6. What are CMutableTransaction tx_to_spend and CMutableTransaction tx_spending? (Defined in src/signet.cpp) Who broadcasts these transactions?

  7. Why was GetWitnessCommitmentIndex() moved? Was anything altered?

  8. (bonus) Did you build the GUI? How does it look different from mainnet?

  9. (double bonus) Why is the signet commitment concatenated to the witness commitment and not in its own OP_RETURN?

Meeting Log

  117:00 <pinheadmz> #startmeeting
  217:00 <michaelfolkson> Can continue after. Meeting starting in seconds
  317:00 <pinheadmz> Welcome to Bitcoin Core PR Review Club! Today's PR is #18267 implementation of BIP-325
  417:00 <pinheadmz> also known as...
  517:00 <felixweis> hi
  617:00 <pinheadmz> πŸŒ‹ πŸŒ‹ πŸŒ‹ πŸŒ‹ πŸŒ‹ πŸŒ‹ πŸŒ‹ πŸŒ‹ πŸŒ‹ πŸŒ‹ πŸŒ‹ πŸŒ‹ πŸŒ‹ πŸŒ‹ πŸŒ‹ πŸŒ‹ πŸŒ‹ πŸŒ‹ πŸŒ‹ πŸŒ‹
  717:00 <pinheadmz> /$$$$$$ /$$$$$$ /$$$$$$ /$$ /$$ /$$$$$$$$ /$$$$$$$$
  817:00 <pinheadmz> /$$__ $$|_ $$_/ /$$__ $$| $$$ | $$| $$_____/|__ $$__/
  917:00 <pinheadmz> | $$ \__/ | $$ | $$ \__/| $$$$| $$| $$ | $$
 1017:00 <pinheadmz> | $$$$$$ | $$ | $$ /$$$$| $$ $$ $$| $$$$$ | $$
 1117:00 <pinheadmz> \____ $$ | $$ | $$|_ $$| $$ $$$$| $$__/ | $$
 1217:00 <pinheadmz> /$$ \ $$ | $$ | $$ \ $$| $$\ $$$| $$ | $$
 1317:00 <pinheadmz> | $$$$$$/ /$$$$$$| $$$$$$/| $$ \ $$| $$$$$$$$ | $$
 1417:00 <pinheadmz> \______/ |______/ \______/ |__/ \__/|________/ |__/
 1517:00 <pinheadmz> πŸŒ‹ πŸŒ‹ πŸŒ‹ πŸŒ‹ πŸŒ‹ πŸŒ‹ πŸŒ‹ πŸŒ‹ πŸŒ‹ πŸŒ‹ πŸŒ‹ πŸŒ‹ πŸŒ‹ πŸŒ‹ πŸŒ‹ πŸŒ‹ πŸŒ‹ πŸŒ‹ πŸŒ‹ πŸŒ‹
 1617:00 <Alistair_Mann> a25
 1717:00 <jonatack> ohai
 1817:00 <nehan> hi
 1917:00 <emzy> hi
 2017:00 <fjahr> hi
 2117:00 <theStack> hi
 2217:00 <@jnewbery> 🀯
 2317:00 <michaelfolkson> Ok.... that is cool
 2417:00 <amiti> hi
 2517:00 <Dylan21m> hi
 2617:00 <michaelfolkson> hi
 2717:01 <sunon> Hey everyone
 2817:01 <robot-dreams> hi
 2917:01 <@jnewbery> steady on pinheadmz. People will expect fireworks every time now
 3017:01 <b10c> hi
 3117:01 <nehan> my expectations for future pr review clubs have gone up
 3217:01 <sipa> ‘ʇǝuΖƒΔ±s
 3317:01 <willcl_ark> hi
 3417:01 <jkczyz> hi
 3517:01 <pinheadmz> jnewbery raising the bar :-) party time!
 3617:01 <pinheadmz> welcome everyone! Please be polite and respectful to each other. Everyone is here to learn and express curiosity.
 3717:01 <jonatack> that literally leaps out of the screen... congrats pinheadmz
 3817:01 <gzhao408> hi!
 3917:01 <pinheadmz> Most of the questions have multiple answers and some of them have kinda tricky answers -- so don't be afraid to take guesses or use your imagination!
 4017:02 <LarryRuane> hello everyone
 4117:02 <pinheadmz> Let's start with a quick sign-in: Two y/n questions:
 4217:02 <pinheadmz> Did you review the PR? / Did you build the branch and connect to signet?
 4317:02 <pinheadmz> y /y
 4417:02 <nehan> y / y
 4517:02 <jkczyz> n / n
 4617:02 <jonatack> y / y
 4717:02 <theStack> n / n
 4817:02 <sunon> n / n
 4917:02 <b10c> n / y
 5017:02 <amiti> y / y
 5117:02 <michaelfolkson> y/y
 5217:02 <Alistair_Mann> y/ny
 5317:02 <robot-dreams> y/y
 5417:02 <LarryRuane> y (sort of) / y
 5517:02 <Dylan21m> y/n
 5617:03 <sipa> Β±/n
 5717:03 <fjahr> y/y but only older version
 5817:03 <@jnewbery> 0.1y/n
 5917:03 <pinheadmz> Those of you that were able to connect and generate a receive address, feel free to drop it here - you might win some worthless signet coins by participating!
 6017:03 <emzy> y
 6117:04 <emzy> y/y
 6217:04 <LarryRuane> tb1qtjtf4hcjq3c9dnx0gy57lpd43427ttq5a8jfzu
 6317:04 <jonatack> tb1qzdu76vyh6cpz9ehdz27u4sf8erzgz76m2kg2rw
 6417:04 <robot-dreams> tb1qgcq63q0qrwe2x2arpdds7rr5ek4qasu9vm80at
 6517:04 <emzy> tb1qplt4vxhanqtepew5te605t2f9k9kkdpvysa89z
 6617:04 <jonatack> send me 1 get 2 back
 6717:05 <pinheadmz> OK let's dig in: Can anyone start us off with a quick definition of signet?
 6817:05 <michaelfolkson> tb1qcdntxa942mg620gnlh6kqs8th3yayqgr7xnmgt
 6917:05 <nehan> tb1qhx8vzcl0hv6mjas06z28t5xt2834h38lz2jj4z
 7017:05 <sipa> building
 7117:05 <amiti> tb1qwhxgd9l9znletzjrd500s8jjgqzuy2mxaevhru
 7217:05 <michaelfolkson> Anyone new here?
 7317:06 <sunon> I’m new
 7417:06 <emzy> jonatack: I'm waiting ;)
 7517:06 <nehan> sunon: welcome!
 7617:06 <Dylan21m> i'm new too.
 7717:06 <subzero> sunon welcome to PR review club
 7817:06 <sunon> Thank you!
 7917:06 <Dylan21m> just watching this time :)
 8017:06 <subzero> welcome Dylan21m !
 8117:06 <pinheadmz> welcome new folks!
 8217:06 <Dylan21m> thank you
 8317:06 <emzy> Welcome!
 8417:07 <pinheadmz> ok Im upping the bounty: 0.1 sBTC for a definition of signet ?!
 8517:07 <jonatack> a stable, centralized testnet
 8617:07 <robot-dreams> signet is a new test network that lets you specify custom block validation requirements; basically a way to have a realistic but sandbox'd test network
 8717:07 <theStack> i'd say signet is a new type of test network, one with an additional requirement for blocks to be accepted (a signature), which allows more control
 8817:07 <jonatack> from optech: Signet is both a tool that allows developers to create networks for testing interactions between different Bitcoin software and the name of the most popular of these testing networks.
 8917:07 <nehan> jonatack: we could have held out for more
 9017:07 <felixweis> n4FggkKF1c7mEbKqqHU6vz6C4gRFSHb51p
 9117:07 <jonatack> nehan: hehe
 9217:07 <pinheadmz> robot-dreams wins a coin!
 9317:08 <pinheadmz> felixweis is that a signet address? perhaps its non-witness? kinda interesting
 9417:08 <sipa> important to stress that signet is both a mechanism to build custom networks with a centralized component, and the name of a specific global testnet
 9517:08 <subzero> pinheadmz signet is construction of the bitcoin network with signatories signing blocks instead of mining which allows rapid testing for network generation for evaluating network performance
 9617:08 <pinheadmz> subzero good answer but also mining still happens - proof of work is still required, but ALSO the sig- rules
 9717:08 <@jnewbery> subzero: not instead of!
 9817:08 <@jnewbery> as well as
 9917:09 <felixweis> pinheadmz: correct, a legacy address on signet
10017:09 <subzero> pinheadmz jnewbery PoW for anti DoS or other reasons?
10117:09 <pinheadmz> felixweis sending you 0.001 just bc ur unique :-)
10217:09 <theStack> alternative definition: "permissioned blockchain" :p
10317:09 <felixweis> <3
10417:09 <nehan> i don't recall seeing anything about "custom block validation requirements" in the first 4 commits -- is that later?
10517:09 <notmandatory> is it possible or anticipated that there will be project specific signet instances? or the a shared signet , like testnet the idea?
10617:09 <@jnewbery> subzero: that's a good question. Maybe pinheadmz will put up a bounty to answer it
10717:09 <michaelfolkson> It is down to the signers. If they don't want anyone else to mine they can stop other people mining
10817:10 <michaelfolkson> But on the default Signet the plan is to let other people mine
10917:10 <pinheadmz> michaelfolkson is that right?
11017:11 <jonatack> emzy: done; bitcoin-cli -signet -datadir=signet sendtoaddress tb1qplt4vxhanqtepew5te605t2f9k9kkdpvysa89z 2 "emzy" "2-for-1" false true 1000 sat/B
11117:11 <pinheadmz> i think in the curent state of the PR only a selected set of users can mine
11217:11 <robot-dreams> nehan: great point, I'm using terminology loosely but basically referring to `CheckSignetBlockSolution`
11317:11 <nehan> robot-dream: ah ok i thought i missed some sort of plug-and-play validation config :)
11417:11 <sipa> what is the current signet height?
11517:12 <michaelfolkson> pinheadmz: Current state maybe... But there really is no point to having proof of work if only the signers are mining
11617:12 <robot-dreams> sipa: I got 2511
11717:12 <pinheadmz> sipa 2511
11817:12 <sipa> me too!
11917:12 <b10c> https://explorer.bc-2.jp/ too
12017:12 <pinheadmz> ok lets get into the questions: Why do we need test networks and what problems (if any) do we have with the current testnet?
12117:12 <sipa> tb1qq5rjrnvp2j0p7m327yrp7ny7dt26qt6y88ed2e
12217:13 <emzy> jonatack: It realy worked! "txid": "deff5000b95dfb22e07e3dde631dabf831f53e0d25e186476625bdc7fe791dfb"
12317:13 <nehan> uh am i on a different signet? I'm at 4015
12417:13 <jonatack> emzy: while stocks last, offer limited to one per person
12517:13 <theStack> pinheadmz: it's permissionless, which is may not always optimal for testing scenarios
12617:13 <pinheadmz> michaelfolkson i think youre question is kinda tied into question 1 here -- what are some of the issues with testnet3? (our current testnet)
12717:14 <@jnewbery> subzero: I believe it's so that any client that works on mainnet can switch to working with signet with minimal changes
12817:14 <emzy> jonatack: I should have send 5 sBTC... ;)
12917:14 <felixweis> takes forever to sync, get started. diff=1 after 20 min is making it a pain to work with
13017:14 <pinheadmz> theStack correct! what kinds of things happen on testnet if "we just let anybody mine" ?
13117:14 <LarryRuane> test networks let us do things that would risk losing real value on mainnet (and we might not have value on mainnet)
13217:14 <robot-dreams> pinheadmz: if "we just let anybody mine", could a troll with lots of mining hardware get the difficult really high and then leave?
13317:14 <nehan> hmm. did signet get restarted in the last few days?
13417:14 <pinheadmz> LarryRuane correct! like lightning network #reckless
13517:14 <sipa> nehan: i believe so
13617:14 <pinheadmz> robot-dreams correct!
13717:15 <theStack> robot-dreams: +1
13817:15 <felixweis> random many 100s of blocks reorgs happen on a regular basis, making every assumptions lightnig e.g. takes for 6 confs = open channel.
13917:15 <jonatack> nehan: yes, reset, new POW
14017:15 <sipa> jnewbery: also DoS protection; PoW correctness is checked before downloading headers; signet signature only when downloading the full block
14117:15 <jonatack> have to reindex or rm -rf
14217:15 <pinheadmz> ill add an answer as well: i was debugging SPV mode on testnet and got stuck on a fork of nodes that are stuck on inflation blocks from last year. theyre still out there. and spv wallets cant tell theyre broken
14317:15 <subzero> isn't another downside to testnet is there a bug in testnet difficulty that roasbeef talked about?
14417:15 <sipa> eh, before downloading *blocks*
14517:15 <nehan> sipa: jonatack: ok!
14617:15 <@jnewbery> nehan: yes, there was an underflow bug with the minimum difficulty so they had to reset
14717:16 <nehan> out-of-band communication necessary to agree on best blockchain
14817:16 <pinheadmz> sipa robot-dreams and jonatack getting coins from a sendmany!
14917:16 <jonatack> istm testnet suffers from large variance in block emission
15017:16 <theStack> considering that mentioned drawback of testnet, it's kind of surprising to me that there have only been three generations of testnet yet (and not more)
15117:16 <sipa> received 88f4ee78856ee88d6eeef3514821ddc6bfa89ca0b6c6146b6b21c8827eb83dd3 !
15217:17 <notmandatory> pinheadmz: is another prob with testnet is since it's random miners it's harder to coordinate reproducing specific mining scenarios to test against?
15317:17 <fjahr> re: PoW I assumed it would have been more code changes and more difficult to review the code if PoW was completely removed
15417:17 <pinheadmz> notmandatory thats interesting and a good point
15517:17 <sipa> fjahr: not to mention it being less representative of the real network
15617:17 <b10c> will testnet3 be deprecated once signet is adopted?
15717:17 <petemyers> Hi I'm new, I'm sorry I didn't say earlier.
15817:17 <pinheadmz> if you WANT to test reorgs, its hard to coordinate one on a public network
15917:17 <pinheadmz> hi petemyers !
16017:17 <jonatack> welcome petemyers
16117:18 <subzero> welcome petemyers
16217:18 <petemyers> Thanks. Just lurking this time.
16317:18 <michaelfolkson> No b10c, it will continue. No way to stop it even if we wanted to
16417:18 <pinheadmz> Ok I'm going to push forward so we can get to more good stuff
16517:18 <pinheadmz> What are some of the parameters that distinguish mainnet, testnet and signet? Which of these do the different networks have in common? What makes signet special?
16617:18 <pinheadmz> lots of answers to this question
16717:18 <michaelfolkson> But it could possibly get reset
16817:18 <b10c> michaelfolkson: thanks
16917:19 <emzy> I'm waiting for a block. Can someone please sign a new one? ;)
17017:19 <robot-dreams> pinheadmz: one small difference is default ports are different: 8333 (mainnet), 18333 (testnet), 38333 (signet)
17117:19 <pinheadmz> robot-dreams yes!!
17217:20 <pinheadmz> robot-dreams is getting sig-rich over here!
17317:20 <pinheadmz> anyone else?
17417:20 <notmandatory> pinheadmz also of course different genesis blocks
17517:20 <michaelfolkson> Only Kalle and AJ are block signers currently emzy
17617:20 <pinheadmz> notmandatory yes!
17717:20 <theStack> pinheadmz: unlike mainnet and testnet, on signet even the most powerful miner could never submit a block if he can't provide the right signature
17817:20 <Alistair_Mann> bitcoin.conf contains signet=1 / or -signet on cli
17917:20 <pinheadmz> theStack great point!!
18017:21 <LarryRuane> if a group of people want to set up their own "private" signet, they'd have to choose different port numbers?
18117:21 <michaelfolkson> Network magic too
18217:21 <pinheadmz> LarryRuane good question, 0.001 sBTC for you -- does any one know?
18317:21 <emzy> michaelfolkson: so who I call first?
18417:21 <pinheadmz> michaelfolkson yes!
18517:21 <michaelfolkson> Whoever you want to wake up emzy ;)
18617:21 <robot-dreams> 🀯 I am at 0.1111 (if I'm lucky maybe I'll get to 0.11111111 by the end of this session)
18717:21 <robot-dreams> 0.111*
18817:22 <LarryRuane> changing port numbers and network magic is a source code change, or can be specified on the command line?
18917:22 <pinheadmz> LarryRuane so i think you are right the ports defined in chainparams but that can be customized
19017:22 <michaelfolkson> I think it is Kalle's script currently mining. So it would be him rather than AJ
19117:22 <pinheadmz> LarryRuane however, the magic bytes would prevent yu from actually connecting to the wrong signet
19217:23 <@jnewbery> powLimit is different between mainnet, regtest and signet
19317:23 <emzy> Could be interesting to have another network magic on the same port...
19417:23 <pinheadmz> jnewbery nice answer, a deep cut
19517:23 <pinheadmz> i will donate your signet btc to charity
19617:24 <jonatack> signet is the only chain where consensus.signet_blocks = true
19717:24 <sipa> changing ports isn't strictly necessary, but it helps if people want to run both networks on one IP
19817:24 <@jnewbery> thank you. benevolent bitcoiners fund please
19917:24 <pinheadmz> jonatack great answer! yes i was about to go there
20017:24 <pinheadmz> so signet is special, not just because it has different magic bytes or p2p ports but it is the only network where checking signet blocks is a thing!
20117:25 <robot-dreams> LarryRuane: yeah, good question: you can specify the port as a command line argument `-port=<port>`, or in the config file; however, I don't think you set network magic this way
20217:25 <pinheadmz> and we kinda touched on this next question already: How many signets are there? Could we start our own just for review club, and if so, how?
20317:26 <theStack> pinheadmz: the sky is the limit :)
20417:26 <pinheadmz> theStack correct! and if we wanted to create a unique signet right now, which `conesensus.______` property would we set ?
20517:27 <michaelfolkson> robot-dreams LarryRuane: The network magic is set for the default Signet in the source code. If you set up a new Signet you would adjust it
20617:27 <robot-dreams> pinheadmz: `signet_challenge`?
20717:27 <jonatack> also the address format: the bech32 human readable parts vary between the chains: bc, tb, bcrt
20817:27 <pinheadmz> michaelfolkson ooooh not just that.... but perhaps the magic bytes get set automatically soemhow ??!?!?!?!??!?!?!
20917:27 <pinheadmz> robot-dreams correct!
21017:27 <theStack> though i guess the practical limit would probably be the possible number of network magic combinations, i.e. ~2^32?
21117:27 <pinheadmz> jonatack correct although we realized signet has the same human-readbale-part as testnet
21217:28 <pinheadmz> theStack thats an interesting point
21317:28 <pinheadmz> but even if we overflow the magic bytes, you can still have unlimited signet_challenge 's
21417:28 <emzy> I think the max signets are 2^256
21517:28 <emzy> * number of
21617:29 <pinheadmz> emzy can you explain how you came up with that ?
21717:29 <jonatack> note that -signet_challenge was just renamed from -signet_blockscript
21817:30 <sipa> i'd say there is an infinity of possible signets... but once you get close to 2^128you run into problems with potential collisions across block hashes (if you care about those)
21917:30 <emzy> pinheadmz: I just tought the magic has someting with the genisis hash in common. But not sure.
22017:30 <pinheadmz> i jsut sent a sBTC sendmany to everyone!!! such great asnwers
22117:30 <sunon> Less than infinity
22217:31 <pinheadmz> emzy well this an interesting point. the magic bytes sort of help us identify peers on the correct network, but the actual "consensus rules" for block validation are set by signet_challenge
22317:31 <pinheadmz> which, as sipa points out, could literally be anything
22417:31 <LarryRuane> the help for -signet_challenge says "Blocks must satisfy the given script to be considered valid" ... what does satisfy mean in this case?
22517:31 <emzy> pinheadmz: right
22617:31 <pinheadmz> and while we're on that note - does anyone know what exactly signet_challenge is? what type of data that is?
22717:31 <notmandatory> pinheadmz does the magic also prevent you from discovering and connecting to the wrong network peer nodes?
22817:31 <pinheadmz> LarryRuane is on the right track
22917:32 <robot-dreams> pinheadmz: not confident, but is it an arbitrary scriptPubKey?
23017:32 <pinheadmz> notmandatory if you recieve a p2p message with the wrong magic bytes ,you just disconnect
23117:32 <pinheadmz> robot-dreams correct! it is an output script
23217:32 <pinheadmz> its sort of arbitrary, but it is the one thing that defines a signet network
23317:32 <michaelfolkson> Any problems with setting up a Signet using the same network magic as an existing Signet network? I'm guessing you'll just get transactions and blocks sent to you you are not interested in?
23417:32 <jonatack> yes...ParseHex(signet_challenge[0]), must be a single value
23517:33 <pinheadmz> michaelfolkson correct it would be like connecting BTC nodes to BCH nodes :-/ (which IIRC have the same port and magic bytes? still? idk)
23617:33 <sipa> michaelfolkson: it just means you won't immediately detect you're connected to the wrong network
23717:33 <pinheadmz> right, you dont disconnect right away but youll figure it out soon enough when all the incoming blocks and txs are invalid
23817:33 <sipa> right, exactly
23917:33 <pinheadmz> so heres a quick bonus Q. the (default) signet_challenege in the PR is:
24017:33 <pinheadmz> 512103ad5e0edad18cb1f0fc0d28a3d4f1f3e445640337489abb10404f2d1e086be430210359ef5021964fe22d6f8e05b2463c9540ce96883fe3b278760f048f5189f2e6c452ae
24117:33 <pinheadmz> does anyone know what this means?
24217:34 <pinheadmz> can transalte into english or at least bitcoin-speak?
24317:34 <sipa> 51 is OP_1
24417:34 <pinheadmz> hint: there is a single rpc command that can *ahem* DECODE this RAW SCRIPT
24517:34 <sipa> 21 means push the next 33 bytes
24617:34 <sipa> what follows looks like a pubkey
24717:35 <pinheadmz> sipa is doing it in his head, of course
24817:35 <jonatack> bitcoin-cli -signet -datadir=signet decodescript
24917:35 <pinheadmz> jonatack yes! so what is this default signet challenge all about ?
25017:36 <emzy> decodescript works
25117:36 <LarryRuane> pinheadmz "but youll figure it out soon enough" ... then what, ban those peers?
25217:36 <jonatack> multisig 2 addresses
25317:36 <pinheadmz> jonatack yep! 0.2 for you
25417:36 <b10c> ae at the end is OP_CHECKMULTISIG
25517:36 <pinheadmz> and what are the m of n values ?
25617:36 <pinheadmz> b10c correct!
25717:36 <sipa> LarryRuane: it's complicated
25817:36 <jrawsthorne> Very late. This is my first time. Anyone want to be generous and send some coins tb1qsk6mtay6kzm9t0gx8lvu07g89d0ty6w4v4qzxm
25917:36 <jrawsthorne> 1 of 2
26017:37 <pinheadmz> jrawsthorne correct!
26117:37 <pinheadmz> sending you worthless coins !
26217:37 <pinheadmz> its a 1 of 2 multisig
26317:37 <pinheadmz> that means there are two private keys that can mine blocks
26417:37 <sipa> LarryRuane: we no longer ban misbehaving peers since recently; they just get discouraged (which means temporarily avoided for new connections, and prioritized for disconnection if we reach our connection limit)
26517:37 <pinheadmz> probably that means two people
26617:38 <pinheadmz> only one of those keys needs to sign for a signet block to be valid
26717:38 <sunon> Two for that specific network?
26817:38 <jonatack> sipa: fwiw signet is "Disconnecting and discouraging peer 49!" ~ every couple minutes
26917:38 <b10c> one key belongs to kalle and one to AJ?
27017:38 <michaelfolkson> For the default Signet
27117:38 <sunon> Ah
27217:38 <michaelfolkson> Yes b10c
27317:39 <pinheadmz> ok we are about to level up everyone -- any lingering questions before we move on to implementation details?
27417:39 <sipa> jonatack: what is the reason? old signet nodes?
27517:39 <pinheadmz> (man we really need a new block, im almost at my unconfrimed limit!)
27617:39 <pinheadmz> ok here we go:
27717:39 <jonatack> afaict it's only people running tor?
27817:39 <pinheadmz> What are CMutableTransaction tx_to_spend and CMutableTransaction tx_spending? (Defined in src/signet.cpp) Who broadcasts these transactions?
27917:39 <emzy> pinheadmz: you know who to call. ;)
28017:40 <jonatack> curious if anyone else is seeing it
28117:40 <pinheadmz> these structures are kinda new in this PR's life and actually BIP-325 was recently updated to include them
28217:40 <jonatack> afaict usually signet by default connects only to one peer, unless you -addnode
28317:40 <robot-dreams> pinheadmz: I think they are generated from a block, as a convenient way to reuse signature validation to check if the _block_ is valid for that signet
28417:41 <sipa> robot-dreams: not just the verification, but signing also
28517:41 <nehan> trick question: no one broadcasts them
28617:41 <pinheadmz> nehan WINNER YES YE SY ES EY SYEYS EY
28717:41 <pinheadmz> im so excited i cant type
28817:41 <pinheadmz> isnt that just so interesting?
28917:41 <sipa> it means all infrastructure that exista for agreeing on and signing transactions can be reused for signet signing
29017:41 <nehan> yeah it's cute to leverage transaction verification for signet verification
29117:41 <pinheadmz> we have these transactions that dont get broadcast at all
29217:42 <pinheadmz> nehan getting 0.1 sBTC for answering my fav question in the meeting today
29317:42 <sipa> they're imaginary transactions :)
29417:42 <robot-dreams> sipa: is this signing done once per block?
29517:42 <sipa> yes
29617:43 <pinheadmz> so why are there two?
29717:43 <pinheadmz> can anyone explain what is happening under the hood here?
29817:43 <pinheadmz> we have these two hard-coded tx templates
29917:43 <emzy> nice usage of transaction verification.
30017:43 <nehan> one to specify the scriptPubKey and another to provide the scriptSig
30117:43 <pinheadmz> and this signet_challenge
30217:43 <felixweis> how do i get a taproot send/spend in a block, isn't it still non-standard so it won't be forwarded by nodes?
30317:43 <pinheadmz> nehan correct!
30417:43 <sipa> has signet forked in taproot already?
30517:44 <pinheadmz> sipa no
30617:44 <michaelfolkson> You can only get a Taproot output in a block felixweis, not spend it
30717:44 <pinheadmz> felixweis you can actually send coins to a witness V1 program right now
30817:44 <pinheadmz> and that output is anyone can spend
30917:44 <sipa> spending would be nonstandard
31017:44 <pinheadmz> yeah and we talked a bit about this last week i think in a taproot review club meeting
31117:45 <felixweis> is there a pushtx php script or so to get it to a miner?
31217:45 <nehan> pinheadmz: i had to blow away my previous signet installation and i deleted my previous wallet :(
31317:45 <pinheadmz> nehan me too :-( good thing coins are free
31417:45 <jonatack> nehan: yup same
31517:45 <pinheadmz> OK so we got these 2 Txs, and we know that the scriptPubKey in the output of the first tx is set by whoever launches the signet or sets it with command line argument
31617:45 <nehan> was curious if there was some smart way to do this without deleting the wallet?
31717:45 <pinheadmz> so the scriptSig and witness though...
31817:46 <jonatack> nehan: reindex i thinx
31917:46 <nehan> jonatack: did not work
32017:46 <pinheadmz> nehan i found all my previous txs were actually abandoned. i think bc the chain reset. no reindex can save you in that state
32117:46 <michaelfolkson> Yup same
32217:46 <jonatack> nehan: oh :(
32317:46 <nehan> pinheadmz: ah yeah the coinbases are new, ok
32417:46 <jonatack> i didn't try, went straight for the rm -rf
32517:47 <petemyers> I gotta go, thanks for letting me watch your discourse about sBTC txs! Toe in the water. A helpful prompt for what I need to read next. See you all next week.
32617:47 * michaelfolkson waves
32717:47 <pinheadmz> Ok 0.1 sBTC for the first answer: The tx_spending scriptSig and witness
32817:47 <pinheadmz> where does it come from?
32917:47 <robot-dreams> pinheadmz: from BIP325, "A block is considered fully validated only if the to_sign transaction is a valid spend of the to_spend transaction"
33017:48 <pinheadmz> robot-dreams yes! so if I am a miner, how do I do that?
33117:48 <pinheadmz> or, more in the scope of this PR - if I am A *validator* where do i look for that data ?
33217:48 <nehan> it's somewehre in the coinbase
33317:48 <robot-dreams> the witness commitment
33417:48 <pinheadmz> coins for robot-dreams and nehan !
33517:49 <pinheadmz> yeah its not really "in" the witness commitment right?
33617:49 <pinheadmz> but, concatenated to it
33717:49 <robot-dreams> right
33817:49 <jonatack> CheckSignetBlockSolution()
33917:49 <pinheadmz> and if kallewoof or aj were here maybe id get an answer to the double-bonus question
34017:49 <sipa> isn't it a separate commitment?
34117:49 <pinheadmz> maybe sipa has insight
34217:49 <nehan> i was confused by the bip spec. why is bytes 1-5?
34317:49 <pinheadmz> ha!
34417:49 <pinheadmz> sipa https://github.com/bitcoin/bips/pull/947/files#r463053062
34517:49 <nehan> Does that mean the first 5 bytes, or a variable length thing?
34617:50 <robot-dreams> pinheadmz: follow-up question for double bonus, would it be harder to find the correct index (instead of just calling the existing `GetWitnessCommitmentIndex`) if we had a separate `OP_RETURN`?
34717:50 <sipa> pinheadmz: ah indeed
34817:50 <pinheadmz> robot-dreams thats a good insight
34917:50 <sipa> not sure that's a good idea
35017:50 <pinheadmz> it could just be to reduce that complexity
35117:51 <pinheadmz> thered have to be a new function `getSignetCommitmentIndex` i suppose
35217:51 <pinheadmz> and also another goal of signet we didnt mention yet is that we want it to otherwise be as close to mainnet as possible
35317:51 <pinheadmz> so idk, miners add extra opreturns for different reasons all the time
35417:51 <pinheadmz> but maybe the design motivation here is just change as little as possible
35517:51 <sipa> perhaps
35617:52 <sipa> it means that "real" consensus extensions (like a second witness...) can'
35717:52 <sipa> use that same position
35817:52 <pinheadmz> oh interesting
35917:52 <pinheadmz> second witness ?
36017:52 <pinheadmz> like an extension block comitment or something?
36117:52 <sipa> for example
36217:52 <sipa> highly hypothetical of course
36317:53 <pinheadmz> good point, this signet spec limits other uses for that one opreturn
36417:53 <pinheadmz> or compact filter comitment
36517:53 <pinheadmz> but i think these could just as easily end up in theri own output anyway right?
36617:53 <robot-dreams> sipa: is it more likely that other consensus extensions would use a new OP_RETURN or use bytes 39 onwards of the witness commitment?
36717:53 <sipa> well signet in such a hypothetical scenario could adapt to either say "the second witness commitment goes after the signet one", or could move itself to the end
36817:53 <jonatack> Kalle, 3 days ago: "I would like to avoid deviating from mainnet parameters as much as possible, permanently." https://github.com/bitcoin/bitcoin/pull/18267#discussion_r484069009
36917:53 <sipa> robot-dreams: who knows
37017:53 <robot-dreams> fair enough :)
37117:53 <sipa> not a big deal
37217:54 <pinheadmz> Ok last 5 minutes!
37317:54 <pinheadmz> Why was GetWitnessCommitmentIndex() moved? Was anything altered?
37417:54 <subzero> is everyone else's signet chain tip: best=000000dcb98799f73c53bc720520064656e40af9e92611cc7e4af6b273eaa2f0 height=2514 ?
37517:54 <pinheadmz> subzero yeah me too
37617:54 <robot-dreams> subzero: yes
37717:55 <nehan> subzero: yes
37817:55 <sipa> 000000dcb98799f73c53bc720520064656e40af9e92611cc7e4af6b273eaa2f0
37917:55 <sipa> (use getchaintips)
38017:55 <pinheadmz> last question is more about the code than the concept
38117:55 <pinheadmz> https://github.com/bitcoin-core-review-club/bitcoin/commit/9620f95e
38217:55 <pinheadmz> why did the author do this?
38317:55 <Alistair_Mann> subzero: yes
38417:55 <emzy> new best=000000dcb98799f73c53bc720520064656e40af9e92611cc7e4af6b273eaa2f0
38517:56 <jonatack> pinheadmz: i recall MarcoFalke asking for it to be moved a few months ago, ~June, but I'd have to look in the GH comments for why
38617:56 <jonatack> subzero: same here
38717:57 * subzero hmm if only there was a digital-only market for establishing chaintip :P
38817:57 <pinheadmz> jonatack interesting yeah i think its a subtlty
38917:57 <pinheadmz> i think it may be so signet.cpp doesnt have to refernece all of validation.cpp?
39017:57 <@jnewbery> I assume so it can be used by other translation units that don't #include validation.h
39117:57 <pinheadmz> yeah
39217:58 <jonatack> something along the lines of don't mix your chocolate with my peanut butter
39317:58 <pinheadmz> and one day maybe we can discuss why we have two vlaidation.cpp 's
39417:58 <pinheadmz> ok last two minutes!
39517:58 <pinheadmz> im going to make it rain on signet right now - coins for all!
39617:58 <pinheadmz> did we miss anyhting?
39717:58 <pinheadmz> any last minute head-scratchers ?
39817:58 <emzy> Free Coinz ;)
39917:58 <notmandatory> will there be signet faucets?
40017:58 <michaelfolkson> How close is this to being merged?
40117:58 <@jnewbery> I have a question? Is the difficulty for the signet genesis block lower than the difficulty for the mainnet genesis block?
40217:58 <pinheadmz> notmandatory yes there is one!
40317:59 <pinheadmz> notmandatory https://signet.bc-2.jp/
40417:59 <nehan> new address: tb1qq5946cjl9zyx93xdcjd6qqgt5zeu5wzxp2xnfp
40517:59 <jonatack> pinheadmz: here it is https://github.com/bitcoin/bitcoin/pull/18267#discussion_r418574248
40617:59 <pinheadmz> haha nehan is avoiding address reuse, good practice
40717:59 <notmandatory> pinheadmz, woo hoo free signet coins ;-)
40817:59 <pinheadmz> jonatack nice find! thank you
40917:59 <sipa> nehan: fwiw, you didn't need to delete your wallet
41017:59 <emzy> I don't care. Is there a mixer for sBTC already?
41117:59 <jonatack> ...or maybe GetWitnessCommitmentIndex was moved again after that
41218:00 <pinheadmz> jnewbery good Q... i know they had to change something about just recently
41318:00 <jonatack> new address: tb1qdef8vxrznlzr0yz6d56gsjldthc6tx5vzvypk5
41418:01 <@jnewbery> maybe leave it as an exercise for the reader?
41518:01 <nehan> sipa: it was an accident :)
41618:01 <pinheadmz> OK thats our time friends !
41718:01 <jonatack> jnewbery: iirc the difficulty was just readjusted
41818:01 <pinheadmz> #endmeeting
41918:01 <pinheadmz> thanks everyone for playing!
42018:01 <@jnewbery> thanks pinheadmz. Great meeting!
42118:01 <pinheadmz> super fun!
42218:01 <robot-dreams> thanks!
42318:01 <@jnewbery> I'm really going to have to raise my game
42418:01 <Alistair_Mann> tyvm pinheadmz!
42518:01 <jonatack> jnewbery: https://github.com/bitcoin/bitcoin/pull/18267#discussion_r483460766
42618:01 <nehan> thanks pinheadmz!
42718:01 <pinheadmz> i spent like 3 BTC
42818:02 <emzy> Thanks pinheadmz!
42918:02 <jonatack> pinheadmz: that was amazing
43018:02 <b10c> Thanks!
43118:02 <pinheadmz> πŸŒ‹ πŸŒ‹ πŸŒ‹
43218:02 <jrawsthorne> Thanks for the free coins I can play around with
43318:02 <subzero> "you get a sig-btc and you get a sig-btc and you get a sig-btc and ..."
43418:02 <emzy> hehe
43518:02 <pinheadmz> jrawsthorne sending more! why not.
43618:03 <michaelfolkson> Thanks pinheadmz!
43718:03 <Alistair_Mann> pacey, upbeat, pinheadmz = willy wonka, this PR his chocolate factory tour. very much enjoyed!
43818:04 <pinheadmz> Alistair_Mann πŸ™ Willy is one of my heros means a lot
43918:04 <Alistair_Mann> :-D
44018:04 <pinheadmz> oh post-credits scene: did anyone build the GUI?
44118:04 <pinheadmz> hows it look? anything unusual about it?
44218:04 <subzero> please sur, may I have some tb1qyjsj4w9kpr88m7d8x9k3wtpfq3638e5kg4jk8w
44318:05 <jrawsthorne> Thanks pinheadmz
44418:05 <subzero> ty pinheadmz !
44518:05 <subzero> fun meeting
44618:05 <LarryRuane> sorry if I missed this, but what's the block explorer URL?
44718:05 <pinheadmz> subzero sent!
44818:05 <emzy> pinheadmz: yes I have the gui running
44918:05 <subzero> pinheadmz ty, got eefab9cba6bed2e3ff5daf1d42ec3d76214e0c58f13e6e8a7681c9736618f3c2
45018:05 <pinheadmz> https://explorer.bc-2.jp/
45118:05 <pinheadmz> LarryRuane ^^
45218:06 <pinheadmz> emzy whaddaya think of the colors ?
45318:06 <emzy> pinheadmz: no, nothing I saw.
45418:06 <pinheadmz> emzy really? no bright yellow BTC logo? :-)
45518:08 <emzy> pinheadmz: the splash screen is empty. But I'm using X11 on macos over ssh X-forward.. So hm.
45618:08 <pinheadmz> oh interesting
45718:08 <jonatack> Question: in CreateGenesisBlock(), is the difficulty determined by the bits parameter?
45818:08 <subzero> I can see the explorer
45918:08 <subzero> just loaded it
46018:09 <LarryRuane> I'm also running the gui, it looks very nice (but I'm not familiar with the mainnet or testnet guis)
46118:09 <emzy> pinheadmz: I can see it for 1sec at the start.
46218:10 <emzy> my test pc is a old pc without monitor... :)
46318:10 <pinheadmz> yeah for me on OSX the dock icon is also bright yellow
46418:10 <pinheadmz> and the splash screen
46518:10 <subzero> dock = tab?
46618:10 <pinheadmz> yeah
46718:10 <pinheadmz> o rlike app switcher command-tab
46818:11 <jonatack> answering my own question: nBits does seem to set the difficulty
46918:11 <pinheadmz> jonatack how do you find the genesis diff though? its not hard coded in chainparams
47018:11 <pinheadmz> do you have to inspect the actual header?
47118:11 <subzero> the dock/tab icon is the same I see on blockstream's esplora webserver next to the "bitcoin explorer" title
47218:12 <jonatack> pinheadmz: in the calls from each chain to CreateGenesisBlock()?
47318:12 <pinheadmz> subzero hm. whats your OS ?
47418:12 <sipa> nBits is a (custom) compressed representation of the target (whose human-readable representation is difficulty)
47518:12 <subzero> pinheadmz that's what I see through Tails
47618:12 <pinheadmz> jonatack ooh gotcha
47718:13 <jonatack> sipa: thank you
47818:13 <pinheadmz> main: 0x1d00ffff signet: 0x1e0377ae
47918:13 <jonatack> so to answer jnewbery's exercise, mainnet and testnet genesis blocks have the same difficulty, signet and regtest no
48018:13 <pinheadmz> jonatack wait did i just read that wrong?
48118:14 <pinheadmz> signet has a higher nbits / easier difficulty target
48218:15 <jonatack> pinheadmz: a little higher; less than regtest
48318:15 <jonatack> which makes sense?
48418:16 <sipa> regtest has constant difficulty though
48518:16 <sipa> while signet difficulty can fluctuate to whatever the signer like
48618:16 <sipa> it's just a minimum
48718:16 <jonatack> good point
48818:23 <LarryRuane> How important is it that signet be DDOS-resistant? Is it important and that's why the signing is required?
48918:24 <sipa> i think it is, to some extent
49018:25 <LarryRuane> just curious, have people attacked testnet? (I know there have been accidental "attacks")
49118:25 <jonatack> is anyone else seeing these every couple of minutes on signet? "Disconnecting and discouraging peer 62!"
49218:26 <jonatack> e.g. "Disconnecting and discouraging peer n!"
49318:26 <subzero> jonatack I am not and I'm on clearnet
49418:27 <jonatack> subzero: thanks. in my previous testing i was on clearnet and did not see them either.
49518:27 <sipa> LarryRuane: bitcoin's normal threat model doesn't consider the cost of block validation to be an issue, as blocks are extremely expensive to create
49618:27 <Alistair_Mann> Only once, approx two hours ago here
49718:28 <jonatack> Alistair_Mann: thanks. clearnet or onion?
49818:28 <subzero> LarryRuane testnet often has highly chaotic behavior, one dev's attack is another dev's test case, there's often times when people need or want certain performance from testnet and there are characteristics of what's going on that are ill suited to that end
49918:29 <LarryRuane> jonatack I'm not seeing those
50018:29 <Alistair_Mann> clearnet only here
50118:29 <jonatack> pinheadmz: after you launched your onion service an hour before the meeting, did you see those on signet?
50218:30 <jonatack> LarryRuane: thanks
50318:30 <jonatack> everyone only had one peer?
50418:30 <jonatack> 178.128.221.177:38333
50518:32 <Alistair_Mann> Implicit is four peers here:
50618:32 <Alistair_Mann> 2020-09-09T17:31:49Z New outbound peer connected: version: 70016, blocks=2512, peer=0 (full-relay)
50718:32 <Alistair_Mann> 2020-09-09T17:31:50Z New outbound peer connected: version: 70016, blocks=4015, peer=2 (full-relay)
50818:32 <subzero> jonatack getpeerinfo shows only your called out peer, for me
50918:33 <Alistair_Mann> 2020-09-09T17:31:50Z New outbound peer connected: version: 70016, blocks=2512, peer=1 (full-relay)
51018:33 <Alistair_Mann> 2020-09-09T17:31:50Z New outbound peer connected: version: 70016, blocks=4015, peer=3 (full-relay)
51118:33 <Alistair_Mann> 2020-09-09T17:31:51Z Disconnecting and discouraging peer 3!
51218:35 <subzero> jonatack my debug.log shows I connected to two peers but getpeerinfo shows only one
51318:36 <subzero> also new signet block released :]
51418:39 <jonatack> Alistair_Mann: rpc getpeerinfo indicates how many peers for you?
51518:39 <jonatack> subzero: thanks
51618:39 <subzero> jonatack do you want me to switch to toronly and test?
51718:39 <Alistair_Mann> Just 178.128.221.177:38333 right now
51818:40 <jonatack> subzero: sure. i've been testing listening both or clearnet and onion.
51918:40 <subzero> jonatack k I will restart with onlynet=onion
52018:40 <jonatack> nice
52118:40 <jonatack> Alistair_Mann: makes sense
52218:54 <subzero> jonatack hmm when I launch onlynet=onion i get "2020-09-09T18:51:45Z Cannot create socket for ntv3mtqw5wt63red.onion:38333: unsupported network"
52318:55 <Alistair_Mann> I have that - and assumed it's because I'm not running a tor proxy
52418:58 <jonatack> subzero: how about if you have tor running and just set listen=1 in your bitcoin.conf
52518:58 <jonatack> and debug=tor if you like
52618:59 <jonatack> (listen is on by default, unless -connect is used)
52718:59 <jonatack> so just launch with tor running
52819:03 <jonatack> subzero: onlynet=onion works for me on signet
52919:05 <subzero> jonatack hmm maybe something's wrong with my tor setup, I show it running `brew services list` but when I start signnet daemon it cannot connect to tor "tor: Not connected to Tor control port 127.0.0.1:9051"
53019:05 <subzero> running curl https://check.torproject.org returns a successful tor connection though
53119:06 <sipa> subzero: that's bitcoind trying to automatically create a hidden service for you
53219:07 <sipa> the warning has no effect on the ability to make outgoing connections through tor
53319:08 <subzero> sipa ah ty, unfortunately debug still shows "Cannot create socket for ntv3mtqw5wt63red.onion:38333" which I interpret as it's not connecting to the peer's onion address, CMIIW
53419:09 <sipa> yeah, indeed
53519:09 <sipa> how are you configuring it?
53619:10 <subzero> launching daemon with: src/bitcoind -signet -datadir=$HOME/Library/Application\ Support/Bitcoin-signet -onlynet=onion -debug=tor
53719:10 <sipa> ah you need to specify the tor proxy
53819:10 <sipa> otherwise bitcoind can't know how to make such connections
53919:11 <sipa> use -onion=localhost:9050 or so
54019:11 <jonatack> maybe something like proxy=127.0.0.1:9050 or 9051
54119:11 <sipa> or -proxy instead of -onion if you also want to use tor for non-hidden-service connections
54219:15 <subzero> ok bingo! adding -proxy=127.0.0.1:9050 no longer prints debut connection errors. Maybe because I don't understand the communication flow of the sockets but I assumed bitcoin would just try to talk to tor automatically on 127.0.0.1:9050
54319:16 <sipa> good
54419:18 <subzero> getpeerinfo showing empty though, debug shows two outbound connections, one with blocks=4015 (maybe that is nehan?)
54519:33 <jonatack> i've tried a few combinations of only onion and onion+clearnet and keep seeing the discouragement messages
54619:35 <subzero> hmm, I seem to never show any getpeerinfo while onlynet=onion
54719:35 <jonatack> i have the impression signet might not yet be on speaking terms with everything in the codebase, there may be some rough edges to smooth out
54819:35 <subzero> maybe this is the reason why: "0 addresses found from DNS seeds"
54919:35 <subzero> reason I'm not having any getpeerinfo
55019:36 <jonatack> oh wait... it's not finding my conf file in the signet folder... d'oh
55119:38 <jonatack> subzero: "0 addresses found from DNS seeds" here too, but that's normal, right?
55219:38 <subzero> as in, "normal for onlynet=onion"?
55319:38 <jonatack> normal for signet
55419:42 <subzero> jonatack I'm not sure of what typical behavior is, but, my debug files never show a non 0 value for that line
55519:44 <sipa> is there a dns seed for signet at all?
55619:44 <sipa> seems yes
55719:45 <subzero> sipa I think there are: "Loading addresses from DNS seed 178.128.221.177" "Loading addresses from DNS seed 2a01:7c8:d005:390::5" "Loading addresses from DNS seed ntv3mtqw5wt63red.onion:38333"
55819:45 <jonatack> you're right
55919:45 <jonatack> i see those as well
56019:46 <subzero> +1
56119:48 <aj> sipa: the signet commitment is identified within the witness commitment by 4-byte prefix, not position, so should be compatible with any other usage as long as the prefix doesn't clash
56219:48 <jonatack> ok i made a new conf file in the right place, and no peers with onlynet=onion
56319:48 <sipa> aj: ah!
56419:54 <aj> sipa: (and if there is a prefix conflict, signet will pick the last push, so if the other thing(s) pick earlier ones, it's maybe okay-ish
56519:55 <aj> )
56619:55 <pinheadmz> aj that answers my Q as well but design-wise, why not just add a coinbase output thats all your own?
56719:56 <aj> pinheadmz: no idea!
56819:56 <pinheadmz> lol ok
56919:56 <aj> pinheadmz: is tb1q0mpex426da5y2f2q3s5us2469yr7k2hcd0xr07 you?
57019:56 <jonatack> correction, with onlynet=onion, i still see peers connecting and then being disconnected and discouraged, and one onion peer: vpytsykcl4w4dr2x.onion:38333
57119:57 <pinheadmz> hm maybe, who wants to know?
57219:57 <pinheadmz> yes it is
57319:57 <pinheadmz> aac71ed737fe861f6252b1ec99268d60bddaef0887f61329c4b7fad844c45e91 from faucet
57419:58 <pinheadmz> oh shit you just made me hella rich
57519:58 <pinheadmz> just seeing "1,000 BTC" is giving me a stomach ache
57619:58 <aj> makin' it rain
57719:58 <pinheadmz> gonna need a few more review clubs lol
57819:59 <aj> well, there'll be a PR at some point with utils for mining custom signets
57920:00 <pinheadmz> haha ok
58020:01 <pinheadmz> oh i misread the blame, the commitment lcoaiton was orignially written by kallewoof
58120:07 <aj> https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2019-March/016754.html is the only related discussion i see; looks to me like the first signet bip draft had it as an extra push in the witness commitment
58220:09 <pinheadmz> welp. I gotta ask more questions on the ML then from now on :-)
58320:09 <aj> https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2018-August/016348.html
58420:18 <aj> felixweis: master+signet considers taproot spends non-standard, so they won't be relayed or mined. you could get a taproot tx in your own mempool by either setting -acceptnonstd or applying the taproot patches on top and setting activation flags, but your tx won't go anywhere or get mined in that case
58520:19 <aj> felixweis: i have a patch series that isn't yet updated for the chain restart that does master+signet+taproot, and also uses a service-flag to allow people running that patchset to connect to each other so that the tx would get relayed amongst peers running those patches; and if a peer running one of those patches was also mining, then (in theory) things would work
58620:19 <aj> felixweis: once things are nailed down a bunch more, maybe it'll be another review club for pinheadmz to run!
58720:20 <pinheadmz> sure I see. pay me 1000 BTC then reset the chain. nice gag :-P
58820:20 <aj> no, no chain resetting involved
58920:22 <aj> (i mean i haven't updated the patch set for the chain restart that just happened the other day)
59020:22 <pinheadmz> πŸŒ‹
59121:10 <felixweis> aj: thanks, very insightful
59223:03 <subzero> jonatack I have yet to encounter a debug message of "Disconnecting and discouraging peer 62!" while running onlynet=onion
59323:09 <aj> (the disconnecting and discouraging is just peers running signet code from a couple of days ago before the genesis block update, presumably)
59423:17 <subzero> aj ah, jonatack and I were poking around thinking maybe it was an issue with onlynet=onion
59523:18 <subzero> that explanation makes sense because only when I ran on onlynet=onion did a see a peer with much higher chain tip hight ( assume that was before the genesis block update
59623:22 <aj> subzero: 4015 was the height of the old chain, i think
59723:22 <subzero> aj yep that was it
59823:22 <aj> the new chain has more work though, despite the lower height (log2_work=32.804431 vs log2_work=33.995256)
59901:40 <kallewoof> once signet is merged into core, and has been rebased in the taproot pull request, it shouldn't be very hard to get taproot enabled on signet
60007:07 <jonatack> aj: i hope so, i've seen 100+ messages like that over the past 12 hours
60107:09 <jonatack> aj: that does make sense though