A weekly review club for Bitcoin Core PRs

What is this?  A weekly club for reviewing Bitcoin Core PRs at 18:00 UTC on Wednesdays on IRC.

What’s it for?  To help newer contributors learn about the Bitcoin Core review process. The review club is not primarily intended to help open PRs get merged (although that might be a nice side-effect).

Who should take part?  Anyone who wants to learn about contributing to Bitcoin Core. All are welcome to come and ask questions!

What’s the benefit for participants?  Reviewing and testing PRs is the best way to start contributing to Bitcoin Core, but it’s difficult to know where to start. There are hundreds of open PRs, many require a lot of contextual knowledge, and contributors and reviewers often use unfamiliar terminology. The review club will give you the tools and knowledge you need in order to take part in the Bitcoin Core review process on GitHub.

How do I take part?

  1. Clone the Bitcoin repository, check out and build the PR branch, and run all tests.
  2. Review the code changes and read the comments on the PR.
  3. Make a note of any questions you want to ask.
  4. Join the #bitcoin-core-pr-reviews IRC channel on freenode at 18:00 UTC on Wednesday.

Who runs this?  Bitcoin Core contributor jnewbery started the review club and schedules the upcoming meetings. Individual meetings are hosted by a variety of Bitcoin Core contributors. See some of our previous hosts.

Upcoming Meetings

We’re always looking for interesting PRs to discuss in the review club and for volunteer hosts to lead the discussion:

Recent Meetings

» #17860 fuzz: BIP 42, BIP 30, CVE-2018-17144 (tests) hosted by MarcoFalke
» #14053 Add address-based index (attempt 4?) (utxo db and indexes) hosted by jnewbery
» #17639 Add make check-valgrind to run the unit tests under Valgrind (tests) hosted by jonatack
» #16702 Supplying and using asmap to improve IP bucketing in addrman (p2p) hosted by jonatack
» #16426 Reverse cs_main, cs_wallet lock order and reduce cs_main locking (wallet) hosted by ariard

See all meetings.

Other Resources for New Contributors