Testing Bitcoin Core 28.0 Release Candidates (tests )
Sep 11, 2024
Host:
rkrux
-
PR author: rkrux
Notes
Major versions of Bitcoin Core are released every 6-8 months. See the Life
Cycle documentation for full details.
When all of the PRs for a release have been merged, Release Candidate 1
(rc1) is tagged. The rc is then tested. If any issues are found, fixes are
merged into the branch and a new rc is tagged. This continues until no major
issues are found in an rc, and that rc is then considered to be the final
release version.
To ensure that users donāt experience issues with the new software, itās
essential that the rcs are thoroughly tested. This special review club
meeting is for people who want to help with that vital review process.
This Bitcoin Core Release Candidate Testing Guide provides guidance for testing the release candidate.
It is recommended to go through the āPreparationā steps ahead of the meeting, especially if you want to compile from
source. Verify and confirm the successful installation of v28rc1, as well as v27.1 (older version is used in couple tests).
Feel free to read the Release Notes
and bring ideas of other things youād like to test!
Meeting Log
1 17:00 <stickies-v> #startmeeting
2 17:00 <stickies-v> hey folks!
3 17:00 <hernanmarino> hey there !
4 17:00 <monlovesmango> hello!
5 17:01 <alfonsoromanz> hello!
9 17:01 <stickies-v> thank you all for joining us for this testing bonanza! is anyone here for the first time? even if youāre just lurking, feel free to say hi!
10 17:03 <stickies-v> rkrux55 has done a wonderful job preparing a guide to facilitate testing the new Bitcoin Core v28 RC1 release, so i'll be handing them the hosting microphone soon
11 17:04 <stickies-v> just to reiterate: review cub is async. even though we'll be going through tests ~progressively, feel free to continue the conversion on earlier or upcoming tests
12 17:04 <stickies-v> the goal is to maximally test the new release, so you're highly encouraged to deviate from the guide and test things that you use, want, think you can break, ...
13 17:05 <stickies-v> with all of that said, and seemingly all familiar faces who very well know how the review club format works - rkrux55 do you want to take it from here?
14 17:05 <rkrux55> yes thank you stickies-v
15 17:05 <rkrux55> hello everyone
18 17:07 <rkrux55> Please share if you face any issues in this section
20 17:08 <stickies-v> glozow: using autotools again does feel unnatural already indeed š
21 17:09 <glozow> stickies-v: crazy how fast you can get used to things
22 17:10 <sipa> you could say it happens... auto-matically š
23 17:11 <glozow> question about section 2 (v3): I assume we need to restart our node with -regtest? So that generate works?
24 17:12 <stickies-v> if no one's having issues getting started i think we can kick off with the testnet4 test rkrux55 ?
26 17:12 <glozow> anyone still building?
27 17:12 <glozow> +1 to moving on
28 17:13 <rkrux55> yes stickies-v we can start with the first testnet4 test
29 17:14 <rkrux55> glozow: yes, the node needs to be restarted with regtest, I'll add in the guide
31 17:16 <glozow> I'll try to do my truc testing on testnet4 :D feels more fun that way
32 17:16 <rkrux55> in the first test, the intent is to connect to the new testnet4 network in v28
33 17:16 <rkrux55> glozow: +1
34 17:17 <glozow> anybody willing to put up a public address on testnet4 to connect to?
35 17:20 <Murch[m]> Sorry, I donāt think my node is accessible from outside our network
36 17:20 <glozow> mine too š
37 17:20 <Murch[m]> Happy to send some testnet4āÆcoins to someone, though
38 17:21 <Murch[m]> I ā¦umā¦ tested the twenty minute exception a few times to mine some
40 17:22 <glozow> should we all share our bestblockhash?
42 17:23 <stickies-v> ugh the macos codesigning requirement for unsigned binaries is really annoying
44 17:23 <Murch[m]> I was able to sync to 44,560 and validated that my chaintip 00000000f1925db8a095cd935d9643fe31bab2ae4aa6b9f529086d4df8852df9 like e.g. mempool.space reports for Testnet4
45 17:24 <glozow> my chaintip is 00000000629dcb986be904639dc4148b2492ec28cbe84d1ebb9baeb60f9432c6, height 44561
46 17:24 <glozow> Murch check again?
47 17:24 <stickies-v> yep i'm also on 00000000629dcb986be904639dc4148b2492ec28cbe84d1ebb9baeb60f9432c6
48 17:24 <glozow> block probably came in as Murch was typing haha
49 17:24 <stickies-v> on bitcoin-qt to spice things up!
51 17:24 <hernanmarino> 00000000629dcb986be904639dc4148b2492ec28cbe84d1ebb9baeb60f9432c6 as well
52 17:25 <glozow> stickies-v: wow!
53 17:25 <Murch[m]> Yeah, the block I reported was height 44,560, yours is 44,561
54 17:25 <rkrux55> mine will take some time to reach the tip
55 17:25 <glozow> Murch: do you wanna send me some testnet4 coins? using a TRUC? ;) we can sibling evict each other?
56 17:25 <glozow> tb1qs3zh2razjv5kf355cxrum9m3sdskuf9ful9fdq
57 17:27 <Murch[m]> mh, lemme see those instructions for creating TRUC transactions
58 17:27 <rkrux55> shall we move to the second test? if anyone is not facing issues connecting with testnet4
59 17:28 <glozow> rkrux55: yes
61 17:29 <rkrux55> this tests the v3 transactions along with few features of TRUC - topologically resticted until confirmation transactions
62 17:30 <rkrux55> such as sibling eviction, being able to replace w/o the need for explicit bip125 signalling
63 17:32 <Murch[m]> glozow: b8dfef71704812a35cd9be9b88ea60f752b54425ca1af6838fafd014a2fbad00
65 17:34 <rkrux55> Guest61: hey
66 17:36 <Murch[m]> glozow: It got cnofirmed already :-/
67 17:37 <glozow> ah crap sorry I didn't see that Murch
68 17:38 <Guest61> So itās over?
69 17:38 <glozow> I did get the coins though! generous!
71 17:38 <glozow> Guest61: we are on section 2, testing TRUC
73 17:39 <Guest61> Ahh I have to be on GitHub
74 17:39 <Guest61> Iām not familiar with GitHub sorry
75 17:40 <glozow> Guest61: you don't need a github account, the guide is just a list of instructions. You can download the binaries from the website if you prefer!
76 17:43 <Murch[m]> glozow: Here is another: 45e5dae5f42f04d35c6d192e474813ad36048ef81cc44c3ec3a61bf06a393e70
77 17:43 <glozow> Murch: on it!
79 17:43 <Murch[m]> Confirmed in 10 seconds
80 17:44 <Murch[m]> The unknown miner is trolling the testing, arenāt they?
81 17:44 <monlovesmango> hahaha
82 17:44 <Murch[m]> 5 blocks in 13 minutes
83 17:44 <glozow> I think all miners know when you're testing block functionality and when you're testing mempool functionality
84 17:44 <Murch[m]> and testing the 20 minute exception rule ^^
85 17:44 <glozow> if it's the former, they will choose to take 60 minutes
86 17:44 <glozow> if the latter, they confirm it for you immediately
87 17:44 <Guest61> Okay thanks
88 17:45 <Murch[m]> ah, the last two blocks are at actual difficulty
89 17:45 <Murch[m]> anyway, enjoy the 6 tāæ
91 17:46 <glozow> hahaha. i mean i guess we can build the parent+children before broadcasting but kind of a pain
92 17:46 <Murch[m]> Anyone else need testnet4 corn, while we are at it?
93 17:46 <Guest61> Yeah I donāt know how to do this either. I am real beginner starting from zero
94 17:47 <Murch[m]> I iterated on my approach, Iām now using sendall with my address as the unspecified amount, and a fixed amount for you, and using as an option {minconf: 0}
95 17:47 <rkrux55> Murch: yes please tb1qw8kwpwtvs2y7e3aj4rpu3m498lnedv9txkhw7h
97 17:49 <Murch[m]> rkrux55: 0108c479401cf81c5715dac49557d7acaa7c5327d173ec583606a924bb258915
98 17:49 <rkrux55> thank you!
99 17:49 <Murch[m]> sibling evict me! ^^
100 17:50 <Murch[m]> I used 13 į¹©/vB
101 17:50 <Murch[m]> b9811e8fb52a4140892c55344cb23c7ab2582148b8d919d74b4002fe8f2bce79
102 17:51 <Murch[m]> uh, actually I used an effective feerate of 13, because of it auto bumping the unconfirmed parent
104 17:51 <Murch[m]> itās 29.2āÆį¹©/vB
105 17:51 <Murch[m]> I used `sendall '["myaddress"]' null "unset" 13 '{"maxconf": 0}'
106 17:51 <Murch[m]> * I used \`sendall '\["myaddress"\]' null "unset" 13 '{"maxconf": 0}'`
107 17:52 <Murch[m]> And confirmed again
108 17:52 <Murch[m]> hehe, okay, I give up
109 17:52 <rkrux55> too fast
110 17:52 <rijndael> im late to the party, but does anyone need any testnet4 corn?
111 17:53 <Murch[m]> Package RBF will be similarly difficult to pull off
113 17:53 <glozow> now i understand why the guide is on regtest hahahaaha
114 17:54 <Murch[m]> glozow: If i build a v3 tx with 0 fee and then a child that spends its output, can I submit it to the mempool and have it end up in the orphanage?
115 17:54 <rkrux55> glozow: lol
116 17:54 <glozow> orphanage is only used from p2p
117 17:54 <glozow> so no, if you're submitting using sendrawtransaction
118 17:55 <glozow> but you can use submitpackage
119 17:55 <Murch[m]> right, but can I even spend it in a child if my node doesnāt know about the parent?
120 17:55 <Murch[m]> rijndael: Howdy! I think we are good, I asked earlier as well, but thanks for offering
122 17:56 <Murch[m]> mhkay, I will try then
123 17:56 <glozow> createrawtransaction and then signrawtransactionwithkey
124 17:56 <glozow> in signrawtransactionwithkey, you may need to provide scriptPubKey and witnessScript
125 17:57 <monlovesmango> skill issue question-trying to use the createrawtransaction command but keep getting error "zsh: no matches found: ["txid":"<tx id here>"]
126 17:58 <monlovesmango> i'm using a txid from listunspent
127 17:58 <glozow> monlovesmango: did you omit bitcoin-cli maybe?
128 17:58 <monlovesmango> no i have "bcli28 creatrawtransaction ...."
129 17:59 <monlovesmango> createrawtransaction*
130 17:59 <monlovesmango> its where that zsh is part of the error right?
131 17:59 <glozow> ah, you may need the quotes and stuff
132 17:59 <monlovesmango> gotcha let me try that
133 17:59 <glozow> bcli28 createrawtransaction "[{\"txid\":
134 17:59 <monlovesmango> hahaha ok will put in all the escapes T.T
135 18:00 <rkrux55> glozow: +1
136 18:00 <monlovesmango> thank you
137 18:00 <glozow> I need to head out now but if anybody has questions in the channel I can get back to them later
138 18:01 <rkrux55> Thanks everyone for joining and testing! Please continue to see if you can break the release.
139 18:02 <glozow> thank you rkrux55 for the excellent guide!!
140 18:02 <rkrux55> thanks glozow for trying it out on testnet4
141 18:02 <monlovesmango> thank you rkrux55!
142 18:02 <hernanmarino> thanks all
144 18:03 <hernanmarino> btw if anyone has some spare testnet4 coins .... tb1qjsguw0rgnggx3fxzcrgz803cq82ptn478xswrn
145 18:04 <rkrux55> #endmeeting
147 18:09 <Murch[m]> <glozow> "in signrawtransactionwithkey..." <- Ah I see.
148 18:09 <instagibbs> gotta bring that utxo info so it'll sign, possibly
149 18:10 <Murch[m]> how do I get the UTXO though, if I havenāt submitted the zero fee parent yet? ^^
150 18:11 <instagibbs> optional args will get ya there, just did it for my own testing
151 18:11 <instagibbs> e.g.
152 18:11 <instagibbs> bitcoin-cli -regtest -rpcwallet=test signrawtransactionwithwallet 0300000001de7615100656cdc2f8fd0217fbbae0d7c6cea020c7d9f64ada16d269db6491bf0000000000fdffffff0100ed94000000000016001400991cdadccdf30cb5a04663b0371cb433a095b400000000 '[{"txid": "bf9164db69d216da4af6d9c720a0cec6d7e0bafb1702fdf8c2cd5606101576de", "vout": 0, "scriptPubKey":
153 18:11 <instagibbs> "001400991cdadccdf30cb5a04663b0371cb433a095b4", "amount": "0.09765625"}]'
154 18:11 <Murch[m]> I see, lemme try
155 18:12 <Murch[m]> (thatās not mentioned in the createrawtransaction doc, I think)
156 18:12 <rkrux55> yeah the signtx needs another arg passing in the prev tx details
157 18:12 <instagibbs> rkrux55 is there an equiv for this in PSBT? I can't recall
158 18:13 <rkrux55> I'm not sure and would need to check, the PSBT would contain the prev output I'd assume
159 18:13 <instagibbs> would need ot make sure the utxo *can* be added without the parent in mempool
160 18:14 <instagibbs> once it's in the PSBT it should work fine
161 18:18 <rkrux55> yes good point
162 18:22 <Murch[m]> instagibbs: I have been trying to use `createpsbt` to make the child transaction with the yet-to-be-created input
163 18:22 <instagibbs> utxoupdatepsbt might need to be extended with a new option, "prevtx" which takes the entire serialized prevtx?
164 18:22 <Murch[m]> I used the "scriptPubKey.hex" value from the decoded parent transaction for the input
165 18:22 <Murch[m]> I still keep getting an incomplete tx, any hints for me?
166 18:23 <instagibbs> hmmmm, incomplete message from signraw? does it add any data or nothing
167 18:23 <instagibbs> If you share steps I can locally recreate
168 18:23 <instagibbs> dm or whatever
169 18:38 <Murch[m]> "package_msg": "success",
170 18:38 <Murch[m]> woooot
171 18:38 <instagibbs> š¤ was the prevtx arg in signrawtransactionwith*
172 18:38 <Murch[m]> "txid": "665f49042e533bcacd3a73fcbe3ac3864705d33af2560f151cd6b289ab3c8272",
173 18:38 <Murch[m]> "txid": "55130f1c87e0fc49d053204f5281b29cdd3775ecf327b92c11fa742a3898c7c1",
174 18:39 <Murch[m]> Anyone got 55130f1c87e0fc49d053204f5281b29cdd3775ecf327b92c11fa742a3898c7c1 in their memepool?
175 18:39 <Murch[m]> mempool.space got it
176 18:39 <Murch[m]> and the 0-fee parent
178 18:45 <Murch[m]> hernanmarino: You should have some coins
179 19:30 <hernanmarino> Murch: Thanks !